Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format,ci: update clang-format to clang16 #3722

Merged
merged 5 commits into from
Jul 31, 2023
Merged

format,ci: update clang-format to clang16 #3722

merged 5 commits into from
Jul 31, 2023

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Jul 28, 2023 •
edited
Loading

  • Updated clang-format to clang-format 16
  • Change C/CXX source file max chars per line from 80 to 100 (@pnorbert, @eisenhauer)
  • Also updated flake8
  • Added script to format your code in your local machine invoking docker internally: scripts/developer/run-clang-format.sh
  • Disabled WriteRead*MissingPerformGets` tests since they were disabled before this big refactoring but after running clang-format they got re-enabled as the gtest TEST_F does not work if its expanded in a multi-line invocation as it was before this PR. This needs to be resolved.

@vicentebolea vicentebolea requested a review from anagainaru as a code owner July 28, 2023 16:57
@vicentebolea vicentebolea requested review from eisenhauer and removed request for anagainaru July 28, 2023 16:58
eisenhauer
eisenhauer previously approved these changes Jul 28, 2023
View reviewed changes
@vicentebolea
Copy link
Collaborator Author

  • Disabled WriteRead*MissingPerformGets` tests since they were disabled before this big refactoring but after running clang-format they got re-enabled as the gtest TEST_F does not work if its expanded in a multi-line invocation as it was before this PR. This needs to be resolved.

@vicentebolea vicentebolea mentioned this pull request Jul 28, 2023
Open
@vicentebolea vicentebolea force-pushed the fix-clang-format branch 3 times, most recently from 56b6a3e to 90a7d92 Compare July 28, 2023 23:56
@vicentebolea vicentebolea enabled auto-merge July 31, 2023 16:50
@vicentebolea vicentebolea merged commit d29e89c into ornladios:master Jul 31, 2023
@vicentebolea vicentebolea deleted the fix-clang-format branch July 31, 2023 18:53
@BrewTestBot BrewTestBot mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eisenhauer eisenhauer eisenhauer approved these changes

@caitlinross caitlinross Awaiting requested review from caitlinross caitlinross is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicentebolea @eisenhauer